Repository navigation
Fix shared CompositePublisher template data binding - #297
Closed
pengpengyi92 wants to merge 1 commit into
Closed
pengpengyi92 wants to merge 1 commit into
pengpengyi92 wants to merge 1 commit into
Conversation
Signed-off-by: Pengyi Peng <pengpengyi92@users.noreply.github.com>
pengpengyi92
requested review from
feussy,
hintse,
ptomecek and
timkpaine
as code owners
November 14, 2026 07:13
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 93.85% 93.86% +0.01%
==========================================
Files 205 205
Lines 22944 22975 +31
Branches 1511 1512 +1
==========================================
+ Hits 21533 21565 +32
Misses 1120 1120
+ Partials 291 290 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 of 11 tasks
Member
|
Thanks for the PR, i've consolidated several open ones in #299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix data being overwritten when
CompositePublisherreuses a configuredpublisher instance. For example, a named
GenericFilePublishercan appear infield_publishers["a"]and indefault_publishersfor fieldb:Currently, both files contain
BETA._get_publishers()stores the originalnamed field publisher, then default selection assigns
BETAto that sameobject before either file is written.
Make the existing shallow
model_copy()before assigning each field's data,for both explicit and default publishers. Named publishers are copied too.
Validation still happens through normal assignment on the copy, and existing
naming, fallback ordering and error handling are unchanged. Configured publisher
templates retain their original data/name/name parameters.
Three regression methods check real file contents for the shared-instance case,
named/unnamed template preservation, and typed default-publisher validation
fallback. No mocked file writer, extra dependency or deep-copy traversal.
Type of Change
Local Validation
Base:
83f2b0ac7128c08c92f2b6fd60f58723ac47635a.This includes existing recursive, root, error-aggregation, file and
PublisherModeltests. It is not a complete repository/version matrix.4 failed, 29 passed, counting the two failing named/unnamed subtests.
There are three new regression methods, not four independent new methods.
because they chdir into a directory before its context exits. All nine also
fail on the completely untouched baseline. No unrelated cleanup fix or test
assertion change is bundled here; the full selection was run on Linux.
git diff --checkpass.Boundary: isolate per-field publisher binding with shallow model copies.
This is not a deep clone of arbitrary nested resources, a thread-safety claim,
or a fix for deliberately identical output paths. Cloud/service integrations,
full
make test/make lintand complete compatibility CI were not run locally.Separate from the typed NumPy serialization work in #296.
Checklist
make lint) - changed-file Ruff checks above passmake test) - scoped native results abovePrepared with AI coding assistance. Reproduction, tests and stated checks were
run locally. DCO sign-off explicitly authorized for this contribution.